Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Possible leftover files when updating mods and NS #36

Closed
0neGal opened this issue Jan 12, 2022 · 2 comments
Closed

fix: Possible leftover files when updating mods and NS #36

0neGal opened this issue Jan 12, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@0neGal
Copy link
Owner

0neGal commented Jan 12, 2022

When updating NS it simply unpacks the zip in the game path, however that means if a file was removed in the core mods, when you then update the old files will still be there, instead we should therefore remove core mods when updating.

We should also do the same when installing mods, aka if a mod is detected to already be installed, remove the original then install, as to avoid those leftover files...

@0neGal 0neGal added the bug Something isn't working label Jan 12, 2022
@0neGal 0neGal changed the title Possible leftover files when updating mods and NS fix: Possible leftover files when updating mods and NS Feb 12, 2022
@Alystrasz
Copy link
Contributor

Regarding mods, we gotta be careful to remove leftover files only and not configuration files, as stated in #42.

@0neGal
Copy link
Owner Author

0neGal commented Jul 31, 2023

#191 incidentally fixes this, as it now deletes the older package when updating.

@0neGal 0neGal closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants