Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a policy analyst or contractor, I need to get manager approval before I my document. #1007

Open
5 of 8 tasks
austinhernandez opened this issue Feb 9, 2018 · 2 comments

Comments

@austinhernandez
Copy link
Member

austinhernandez commented Feb 9, 2018

Assumptions

  • The user is done proofreading and editing a policy and needs a manager or SME approval before the a policy live on the OMB Policy Library.

Actions

  • Create mechanism for "in review" or "approval."
  • Design warning label, button, or screen that alerts a user that they need approval
  • Notify user of success (screen, alert, etc.)
  • Determine if the documents needs an "in review" status.
  • Publish button gives clear language and understanding to the publisher that this is final and will be public
  • Finalize text and applicable error states
  • Design applicable warning labels, buttons, or screen that alerts a user that they need approval

Considerations

Not for MVP:

  • As a SME or supervisor, I want to be able to track changes to policy documents and be able to revert to old versions, so that we can correct any mistakes that might be introduced.
  • As a SME or supervisor, I want a feature that allows my Policy Analysts to notify me by email with a direct link to the policy in question when something is ready for review to be published so that I can easily track, approve, and publish documents.
@austinhernandez
Copy link
Member Author

austinhernandez commented Feb 9, 2018

Interaction deets

  • Publish button is set to inactive until the user checks the This document has been reviewed by a supervisor box.
  • After a user clicks to indicate they have had the document reviewed, the Publish button will be clickable!
  • Question for team: Should we set this the workflow status to in review after click and display it or for MVP?

Full preview page

image

Interaction detail (checkbox unselected)

image

Text needs content approval and/or wordsmithing, @thebestsophist. Currently:

  • [call to action primary] Publish
  • [call to action tertiary] Save and close
  • [checkbox] "[ ] This document has been reviewed by a supervisor"

Interaction detail (checkbox selected)

image
Now it's clickable and you can proceed!

Interaction detail (warning screen)

image

  • Not so fast! It's not that easy to publish policy live to the OMB site. You gotta be double sure.
  • This needs wordsmithing, too, @thebestsophist
  • [header] Before you publish
  • [subheader] You are about to publish this document to the OMB Policy Library. Before you publish, please ensure the following:
    • Document has been spell-checked and edited for errors
    • Document has undergone supervisor or SME approval
    • Document accurately represents the original signed policy
  • [call to action primary] I certify – publish to library
  • [call to action secondary] Save without publishing
  • [call to action secondary] Edit
  • X button closes the modal and just shows you the preview page. No action taken.

@austinhernandez
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants