Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ProseMirror editor, document util.walkUpUntil() #1032

Open
toolness opened this issue Feb 16, 2018 · 0 comments
Open

In ProseMirror editor, document util.walkUpUntil() #1032

toolness opened this issue Feb 16, 2018 · 0 comments
Assignees
Labels

Comments

@toolness
Copy link
Contributor

I was writing some code today and decided to use util.walkUpUntil() but it wasn't immediately obvious what it'd return if it didn't find a node that matched the predicate. After reading the code, I intuited that it was -1, but it'd be nice to document.

Also, it'd be nice to document the return type in the function signature too!

@yowill yowill added this to the X... Sprint milestone Feb 20, 2018
@cmc333333 cmc333333 self-assigned this Feb 20, 2018
@yowill yowill added the Small label Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants