Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons pressed but text not skipped with current version #46

Open
mokahless opened this issue Oct 8, 2024 · 4 comments
Open

Buttons pressed but text not skipped with current version #46

mokahless opened this issue Oct 8, 2024 · 4 comments

Comments

@mokahless
Copy link

The new version I downloaded today will not advance dialogue but will properly select dialogue options. The .env file properly reports 3840x2160 and ensured I'm running as administrator. When I use the older version from July, it works properly. Only other thing I can think of that might be relevant is I run multi-monitor but again, no issues with the July version.

This seems similar to issue #30 but issue #30 was from months before both the versions I have so if it is at all related, then it might be a regression.

I tested and confirmed this isn't this bug: "If the dialogue starts with an option right out of the blue then the script wont start until you click on an option." by advancing dialogue myself past a few options.

@0withoutface0
Copy link
Contributor

Thanks for the report, it should be something to do with the higher resolution. I will try to take a look soon (possibly next week). If posible can we get in touch on discord so you can test it out for me? I dont have a 4k display so its quite difficult for me to test that resolution.
It might be a problem with the y coordinates bc i only made sure of the x coordinates being precise but couldnt make sure of the y ones.

Until then, please use the older version from july.

@0withoutface0
Copy link
Contributor

@mokahless Can you give me your discord username? I just made some changes to the code and i would like you to test if it works. Would appreciate it a lot!

@mokahless
Copy link
Author

mokahless commented Nov 20, 2024

Sorry, I'm not very active online, nor do I have discord but I check back once in a while. I'll try and test it today.

That said, it might be moot anyway. The latest Genshin version supports "f" to select dialogue options. Even better, you don't need to start scrolling up and down either which means the script can be changed to just pressing "f" (besides receiving items and other such edge cases).

Edit: Tested. New version at 4K detects the resolution properly and selects the dialogue options to continue, but does not advance the texts otherwise.

0withoutface0 added a commit to 0withoutface0/genshin-dialogue-autoskip-widescreen that referenced this issue Nov 29, 2024
…e original height calculation for height no matter how wide the screen is.

more info in issue 1hubert#46

Also: Whole script can be simplified thanks to a new genshin update which lets you select options with the F key.
0withoutface0 added a commit to 0withoutface0/genshin-dialogue-autoskip-widescreen that referenced this issue Nov 29, 2024
…e original height calculation for height no matter how wide the screen is.

more info in issue 1hubert#46

Also: Whole script can be simplified thanks to a new genshin update which lets you select options with the F key.
@0withoutface0
Copy link
Contributor

@mokahless
I haven't updated the script yet so no result was expected. I just made a commit a few minutes ago which might fix the issue. Try downloading that one. Here is the link to it if you are reading this before it gets merged: modified fork

Thanks for your contributions by testing! I appreciate it a lot. I won't have time to implement the new F key feature, but the current version should work just fine. I don't play genshin anymore because I'm pretty busy nowadays so I will only be able to fix small bugs. If i ever have time to be more active i will definitely improve this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants