Generic HTTP adapter [THREESCALE-2665] #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
generic-http-adapter
branch
2 times, most recently
from
fa80beb
to
9a169a2
Compare
mikz
force-pushed
the
generic-http-adapter
branch
7 times, most recently
from
fc1d8de
to
831ae06
Compare
mikz
force-pushed
the
generic-http-adapter
branch
from
831ae06
to
6215519
Compare
hallelujah
reviewed
Jun 3, 2019
hallelujah
reviewed
Jun 3, 2019
hallelujah
reviewed
Jun 3, 2019
|
|
||
| raise InvalidResponseError, { response: response, message: body } unless response.ok? | ||
|
|
||
| params = body.try(:to_h) or return # no need to create client if there are no attributes |
There was a problem hiding this comment.
If the content-type is NULL_TYPE, body will be a String
https://github.com/3scale/zync/pull/196/files#diff-cbd4720b5437174ca7b9bcc0a46568adR99
Probably you want to return nil then it is fine
There was a problem hiding this comment.
Which is fine, because it will return nil and return.
hallelujah
reviewed
Jun 3, 2019
hallelujah
reviewed
Jun 3, 2019
hallelujah
reviewed
Jun 3, 2019
hallelujah
reviewed
Jun 3, 2019
|
|
||
| adapter = GenericAdapter.new('http://id:secret@lvh.me:3000/auth/realm/name') | ||
|
|
||
| begin |
There was a problem hiding this comment.
Without begin/rescue
error = assert_raises GenericAdapter::OIDC::AuthenticationError do
adapter.test
end
assert_kind_of Faraday::TimeoutError, error.cause
assert error.bugsnag_meta_data.presenceThere was a problem hiding this comment.
I'll revert your d34e9d1. Feel free to apply those changes when they are working. But I need to merge & deploy this.
There was a problem hiding this comment.
Fair enough, I will work on it
mikz
force-pushed
the
generic-http-adapter
branch
from
d34e9d1
to
60a191b
Compare
mikz
force-pushed
the
generic-http-adapter
branch
from
60a191b
to
ac2eaec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An adapter implementing 1228d79 protocol.
Depends on 3scale/porta#829