diff --git a/action/recipes/edk2.go b/action/recipes/edk2.go index d5043bcd..1b45400f 100644 --- a/action/recipes/edk2.go +++ b/action/recipes/edk2.go @@ -32,15 +32,13 @@ func edk2(ctx context.Context, client *dagger.Client, common *commonOpts, docker return err } - // There is no copying of config file at "defconfig_path" - // content of the config file at "defconfig_path" should be read into string instead - // Setup environment variables in the container for key, value := range envVars { myContainer = myContainer.WithEnvVariable(key, value) } // Assemble build arguments + // and read content of the config file at "defconfig_path" buildArgs := fmt.Sprintf("-a %s -p %s -b %s", common.arch, opts.platform, opts.releaseType) defconfigFileArgs, err := os.ReadFile(common.defconfigPath) if err != nil { diff --git a/action/recipes/edk2_test.go b/action/recipes/edk2_test.go index 4c8e02aa..37c94603 100644 --- a/action/recipes/edk2_test.go +++ b/action/recipes/edk2_test.go @@ -85,7 +85,7 @@ func TestEdk2(t *testing.T) { assert.NoError(t, err) defer os.Chdir(pwd) // nolint:errcheck - // Clone coreboot repo + // Clone edk2 repo cmd := exec.Command("git", "clone", "--recurse-submodules", "--branch", tc.edk2Version, "--depth", "1", "https://github.com/tianocore/edk2.git", "Edk2") err = cmd.Run() assert.NoError(t, err)