Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioning to Binary Format in fs-storage Crate #22

Open
tareknaser opened this issue Apr 4, 2024 · 1 comment
Open

Transitioning to Binary Format in fs-storage Crate #22

tareknaser opened this issue Apr 4, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tareknaser
Copy link
Collaborator

We should consider migrating to a binary file format for the fs-storage crate. One potential crate is bincode.
For context, I came across some benchmarks for Rust serialization frameworks, which could be valuable. You can find them here.

Additionally, I just noted that the current output from FileStorage does not output a valid JSON file. The output is:

version 2
{"a":"1","b":"2","c":"3"}

It's also worth noting that the file doesn't have .json extension.

@tareknaser tareknaser added the enhancement New feature or request label Apr 4, 2024
@tareknaser tareknaser self-assigned this Apr 18, 2024
@kirillt
Copy link
Member

kirillt commented Apr 28, 2024

That would be great at some point.

These points seem to be prerequisites for transition to binary format:

  • Stabilize APIs
  • Integrate with at least several apps
  • Benchmark and profile storages

I believe that binary format will speed things up, but we should work on it when performance becomes an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants