get partitioning measures: 229 #249

TebaleloS · 2024-08-20T10:06:29Z

Release notes:

Endpoint functionality to get partitioning measures by partitioning ID.
Defined SQL function to get the measures by ID.
Defined and implemented the class to call the DB function.
Implemented the endpoint functionality all the way from the repository to the endpoint.
Added integration and unit tests.

github-actions · 2024-08-20T10:09:04Z

JaCoCo model module code coverage report - scala 2.13.11

Overall Project	63.64%	🍏

There is no coverage information present for the Files changed

github-actions · 2024-08-20T10:09:05Z

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project	85.84%	🍏

There is no coverage information present for the Files changed

github-actions · 2024-08-20T10:09:05Z

JaCoCo server module code coverage report - scala 2.13.11

Overall Project	76.47% `-1.11%`	🍏
Files changed	87.6%	🍏

File	Coverage
PartitioningRepositoryImpl.scala	100%	🍏
PartitioningServiceImpl.scala	100%	🍏
PartitioningControllerImpl.scala	80.9% `-12.36%`	❌
GetPartitioningMeasuresById.scala	80% `-28.82%`	🍏

# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningController.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningServiceImpl.scala # server/src/test/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryUnitTests.scala

# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningController.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Endpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Routes.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepository.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningService.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningServiceImpl.scala # server/src/test/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/service/PartitioningServiceUnitTests.scala

TebaleloS · 2024-08-30T09:57:26Z

Release notes:

Endpoint functionality to get partitioning measures by partitioning ID.
Defined SQL function to get the measures by ID.
Defined and implemented the class to call the DB function.
Implemented the endpoint functionality all the way from the repository to the endpoint.
Added integration and unit tests.

github-actions · 2024-09-02T15:14:11Z

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project	100%	🍏

There is no coverage information present for the Files changed

salamonpavel · 2024-09-04T06:06:00Z

server/src/main/scala/za/co/absa/atum/server/api/http/BaseEndpoints.scala

@@ -71,7 +71,8 @@ trait BaseEndpoints {
      oneOf[ErrorResponse](
        badRequestOneOfVariant,
        generalErrorOneOfVariant,
-        internalServerErrorOneOfVariant
+        internalServerErrorOneOfVariant,
+        notFoundErrorOneOfVariant


Not here in the base endpoint, add this to the getPartitioningMeasuresEndpointV2. The base endpoint should provide only things common to every single endpoint. Looking at the getPartitioningMeasuresEndpointV2 it's actually already there so what was the reason to add it here as well?

I actually didn't check it. Thank you for the alert, I will remove it.

salamonpavel · 2024-09-04T06:11:28Z

...r/src/test/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryUnitTests.scala

+            failsWithA[NotFoundDatabaseError]
+          )
+        },
+        test("Returns expected DatabaseError") {


GeneralDatabaseError

# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala

...test/scala/za/co/absa/atum/database/runs/GetPartitioningMeasuresByIdV2IntegrationTests.scala

…tioningMeasuresByIdV2IntegrationTests.scala Co-authored-by: David Benedeki <14905969+benedeki@users.noreply.github.com>

benedeki

code reviewed
pulled
built
run

TebaleloS added 2 commits August 20, 2024 11:32

Defining and implementing PL/PG function

29d3750

Defining measure dto

d51000c

TebaleloS self-assigned this Aug 20, 2024

TebaleloS added 19 commits August 26, 2024 09:18

Removing measure ID

b1bf7c4

Merge branch 'master' into feature/229-get-partitioning-measures

b58c814

defining get class to call db-function

70fbe30

Implement db call class

1763353

removing unused import

a434181

adding integration tests

b8dfddf

restoring db-function

a95ed41

Adding test and fixing the build

857dd02

Adding tests layer and updating sql function

880b435

Implementing service functionality

1098791

Implementing Controller functionality

32862a0

fixing return type

8457553

fixing merge conflicts

6a691b4

Adding the endpoint

74a8c45

Adding repository unit test

415739f

Adding service unit test

78132bb

Fixing merge conflicts

6a6786d

TebaleloS added Server Issues touching the server part of the project work in progress Work on this item is not yet finished (mainly intended for PRs) labels Aug 30, 2024

TebaleloS added 2 commits August 30, 2024 11:43

Fixing fileName conflicts

a6f627c

removing unused file

2df573a

TebaleloS added 6 commits September 2, 2024 09:54

Changing file name

02dbe17

fixing file format

760eac3

Removing outdated tests

448cb33

Fixing the function and the test cases

bcfbe5b

Merge branch 'master' into feature/229-get-partitioning-measures

6f4ba3c

Restoring files

fdcdb7e

TebaleloS added 2 commits September 2, 2024 20:08

implementing endpoint test-cases

94611e1

Fixing endpoint tests

8f5bdc1

TebaleloS marked this pull request as ready for review September 2, 2024 18:40

TebaleloS requested review from benedeki, lsulak, Zejnilovic, dk1844 and salamonpavel as code owners September 2, 2024 18:40

TebaleloS removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Sep 2, 2024

salamonpavel reviewed Sep 4, 2024

View reviewed changes

TebaleloS added 2 commits September 4, 2024 09:40

Merge branch 'master' into feature/229-get-partitioning-measures

18faca9

# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala

Addressing GitHub comments

bcce813

salamonpavel previously approved these changes Sep 4, 2024

View reviewed changes

benedeki reviewed Sep 4, 2024

View reviewed changes

...test/scala/za/co/absa/atum/database/runs/GetPartitioningMeasuresByIdV2IntegrationTests.scala Outdated Show resolved Hide resolved

...test/scala/za/co/absa/atum/database/runs/GetPartitioningMeasuresByIdV2IntegrationTests.scala Show resolved Hide resolved

TebaleloS dismissed salamonpavel’s stale review via 9556fd1 September 4, 2024 11:12

TebaleloS and others added 2 commits September 4, 2024 13:12

Update database/src/test/scala/za/co/absa/atum/database/runs/GetParti…

9556fd1

…tioningMeasuresByIdV2IntegrationTests.scala Co-authored-by: David Benedeki <14905969+benedeki@users.noreply.github.com>

Update database/src/test/scala/za/co/absa/atum/database/runs/GetParti…

d4a49fa

…tioningMeasuresByIdV2IntegrationTests.scala Co-authored-by: David Benedeki <14905969+benedeki@users.noreply.github.com>

benedeki approved these changes Sep 4, 2024

View reviewed changes

TebaleloS merged commit d31eded into master Sep 4, 2024
10 checks passed

TebaleloS deleted the feature/229-get-partitioning-measures branch September 4, 2024 11:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

get partitioning measures: 229 #249

get partitioning measures: 229 #249

TebaleloS commented Aug 20, 2024 •

edited by miroslavpojer

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

TebaleloS commented Aug 30, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

salamonpavel Sep 4, 2024 •

edited

Loading

TebaleloS Sep 4, 2024

salamonpavel Sep 4, 2024

benedeki left a comment

get partitioning measures: 229 #249

get partitioning measures: 229 #249

Conversation

TebaleloS commented Aug 20, 2024 • edited by miroslavpojer Loading

github-actions bot commented Aug 20, 2024 • edited Loading

JaCoCo model module code coverage report - scala 2.13.11

github-actions bot commented Aug 20, 2024 • edited Loading

JaCoCo agent module code coverage report - scala 2.13.11

github-actions bot commented Aug 20, 2024 • edited Loading

JaCoCo server module code coverage report - scala 2.13.11

TebaleloS commented Aug 30, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

JaCoCo reader module code coverage report - scala 2.13.11

salamonpavel Sep 4, 2024 • edited Loading

Choose a reason for hiding this comment

TebaleloS Sep 4, 2024

Choose a reason for hiding this comment

salamonpavel Sep 4, 2024

Choose a reason for hiding this comment

benedeki left a comment

Choose a reason for hiding this comment

TebaleloS commented Aug 20, 2024 •

edited by miroslavpojer

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

TebaleloS commented Aug 30, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

salamonpavel Sep 4, 2024 •

edited

Loading