Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get partitioning measures: 229 #249
get partitioning measures: 229 #249
Changes from 31 commits
29d3750
d51000c
b1bf7c4
b58c814
70fbe30
1763353
a434181
b8dfddf
a95ed41
857dd02
880b435
1098791
32862a0
8457553
5791887
6a691b4
74a8c45
415739f
78132bb
6ba1114
6a6786d
a6f627c
2df573a
02dbe17
760eac3
448cb33
bcfbe5b
6f4ba3c
fdcdb7e
94611e1
8f5bdc1
18faca9
bcce813
9556fd1
d4a49fa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not here in the base endpoint, add this to the getPartitioningMeasuresEndpointV2. The base endpoint should provide only things common to every single endpoint. Looking at the getPartitioningMeasuresEndpointV2 it's actually already there so what was the reason to add it here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually didn't check it. Thank you for the alert, I will remove it.