Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding in-active endpoints: #263 #277

Merged

Conversation

TebaleloS
Copy link
Collaborator

@TebaleloS TebaleloS commented Sep 25, 2024

Release notes:

  • This PR implement the functionality if hiding in-active endpoint from swagger documentation.

Closes #263

@TebaleloS
Copy link
Collaborator Author

Release notes

  • This PR implement the functionality if hiding in-active endpoint from swagger documentation.

@TebaleloS TebaleloS self-assigned this Sep 25, 2024
Copy link

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 63.64% 🍏

There is no coverage information present for the Files changed

Copy link

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 84.63% 🍏

There is no coverage information present for the Files changed

Copy link

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project 100% 🍏

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Sep 25, 2024

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 72.57% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

@benedeki benedeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just to solve the questions.
Mind that in case of conflicts (other endpoints merged) the list can be edited on either side.

createPartitioningEndpointV1,
postPartitioningEndpointV2,
// postPartitioningEndpointV2,
patchPartitioningAdditionalDataEndpointV2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you guys know, if we use this endpoint in Agent now? @salamonpavel @lsulak

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, PATCH wasn't introduced into the agent.

Agent is using this endpoint: POST /api/v2/writeAdditionalData

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually perhaps we should adjust the agent to work with this PATCH because otherwise we got incompatibility in 0.3.0 between agent and server

@TebaleloS TebaleloS marked this pull request as ready for review September 27, 2024 07:31
benedeki
benedeki previously approved these changes Sep 30, 2024
@TebaleloS
Copy link
Collaborator Author

Release notes

  • This PR implement the functionality if hiding in-active endpoint from swagger documentation.

@TebaleloS TebaleloS force-pushed the feature/#263-Hide-non-active-endpoints-v2-from-swagger branch from c433c8a to b27a7fa Compare October 1, 2024 08:23
@TebaleloS TebaleloS merged commit 7889f62 into master Oct 1, 2024
16 checks passed
@TebaleloS TebaleloS deleted the feature/#263-Hide-non-active-endpoints-v2-from-swagger branch October 1, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants