Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#234: Docker changes related to ZIO & custom config #279

Merged
merged 6 commits into from
Sep 27, 2024
Merged

#234: Docker changes related to ZIO & custom config #279

merged 6 commits into from
Sep 27, 2024

Conversation

lsulak
Copy link
Collaborator

@lsulak lsulak commented Sep 25, 2024 •
edited by miroslavpojer
Loading

Closes #278

Release notes:

  • Dockerfile adjusted to ZIO framework and custom configuration now being passed during docker run, i.e. independent of the sbt build and docker build

@github-actions GitHub Actions
Copy link

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 63.64% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 84.63% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project 100% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 74.14% 🍏

There is no coverage information present for the Files changed

@lsulak lsulak changed the title #234: post-review simplification #234: Docker changes related to ZIO & custom config Sep 26, 2024
salamonpavel
salamonpavel approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@salamonpavel salamonpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, tested on my laptop. Good job!

@lsulak
Copy link
Collaborator Author

lsulak commented Sep 27, 2024 •
edited
Loading

Release notes:

  • Dockerfile adjusted to ZIO framework and custom configuration now being passed during docker run, i.e. independent of the sbt build and docker build

@lsulak lsulak merged commit 73c19b5 into master Sep 27, 2024
10 checks passed
@lsulak lsulak deleted the feature/278-docker-zio-compatibility branch September 27, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salamonpavel salamonpavel salamonpavel approved these changes

@benedeki benedeki Awaiting requested review from benedeki benedeki is a code owner

@TebaleloS TebaleloS Awaiting requested review from TebaleloS

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker changes related to ZIO
2 participants
@lsulak @salamonpavel