Feature/#63 create build matrix and build action #64

TebaleloS · 2023-07-21T06:28:54Z

Notes

Added sbt build matrix
Added Jacoco code coverage configs

Closes #63

…rage.

miroslavpojer · 2023-07-27T08:31:14Z

I am missing Jacoco GH Action. Support for Jacoco itself has been add, but GH Action workflow is missing. It should be added together.
Please, decide if mention Jacoco in root Readme file.
Get inspiration in atum repository.

miroslavpojer

miroslavpojer · 2023-07-27T08:51:40Z

project/Dependencies.scala

+    Seq(
+        "org.apache.spark" %% "spark-core"                               % sparkVersion % Provided,
+        "org.apache.spark" %% "spark-sql"                                % sparkVersion % Provided,
+        "com.typesafe"      % "config"                                   % typesafeVersion, //TODO to check if used


Found TODO in this file.
In the code there are 4 another TODOs - these should be updated with Issue where is planned to solved them.

project/JacocoSetup.scala

project/plugins.sbt

.github/workflows/release.yml

version.sbt

project/plugins.sbt

Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>

…and-build-action' into feature/#63-Create-build-matrix-and-build-action

github-actions · 2023-08-03T15:21:57Z

JaCoCo server module code coverage report - scala 2.12.12

File	Coverage [0%]	❌
package.scala	0%	❌

Total Project Coverage	12.45%	❌

github-actions · 2023-08-03T15:22:47Z

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

File	Coverage [69.28%]	❌
MeasureResult.scala	100%	🍏
AtumAgent.scala	100%	🍏
AtumContext.scala	95.28%	🍏
Measurement.scala	54.61%	❌
MeasurementProcessor.scala	0%	❌

Total Project Coverage	69.28%	❌

github-actions · 2023-08-03T15:22:49Z

JaCoCo server module code coverage report - scala 2.12.12

File	Coverage [0%]	❌
package.scala	0%	❌

Total Project Coverage	12.45%	❌

…and-build-action' into feature/#63-Create-build-matrix-and-build-action

github-actions · 2023-08-04T06:27:53Z

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

File	Coverage [69.28%]	❌
MeasureResult.scala	100%	🍏
AtumAgent.scala	100%	🍏
AtumContext.scala	95.28%	🍏
Measurement.scala	54.61%	❌
MeasurementProcessor.scala	0%	❌

Total Project Coverage	69.28%	❌

github-actions · 2023-08-04T06:27:55Z

JaCoCo server module code coverage report - scala 2.12.12

File	Coverage [0%]	❌
package.scala	0%	❌

Total Project Coverage	12.45%	❌

github-actions · 2023-08-04T07:58:13Z

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

File	Coverage [69.28%]	❌
MeasureResult.scala	100%	🍏
AtumAgent.scala	100%	🍏
AtumContext.scala	95.28%	🍏
Measurement.scala	54.61%	❌
MeasurementProcessor.scala	0%	❌

Total Project Coverage	69.28%	❌

github-actions · 2023-08-04T07:58:14Z

JaCoCo server module code coverage report - scala 2.12.12

File	Coverage [0%]	❌
package.scala	0%	❌

Total Project Coverage	12.45%	❌

github-actions · 2023-08-04T11:08:04Z

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

File	Coverage [69.28%]	❌
MeasureResult.scala	100%	🍏
AtumAgent.scala	100%	🍏
AtumContext.scala	95.28%	🍏
Measurement.scala	54.61%	❌
MeasurementProcessor.scala	0%	❌

Total Project Coverage	69.28%	❌

github-actions · 2023-08-04T11:08:05Z

JaCoCo server module code coverage report - scala 2.12.12

File	Coverage [0%]	❌
package.scala	0%	❌

Total Project Coverage	12.45%	❌

.github/workflows/license_check.yml

.github/workflows/jacoco_check.yml

lsulak · 2023-08-07T14:05:54Z

build.sbt

  )
  .enablePlugins(TomcatPlugin)
  .enablePlugins(AutomateHeaderPlugin)
+  .jvmPlatform(scalaVersions = Seq(scala212))


won't scala 2.11 be supported?

It will be supported but again, 2.12 should be the default version.

Good for now. 2.13 should be added eventually too.

.github/workflows/jacoco_check.yml

github-actions · 2023-08-08T11:14:58Z

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

File	Coverage [69.28%]	❌
MeasureResult.scala	100%	🍏
AtumAgent.scala	100%	🍏
AtumContext.scala	95.28%	🍏
Measurement.scala	54.61%	❌
MeasurementProcessor.scala	0%	❌

Total Project Coverage	69.28%	❌

github-actions · 2023-08-08T11:14:59Z

JaCoCo server module code coverage report - scala 2.12.12

File	Coverage [0%]	❌
package.scala	0%	❌

Total Project Coverage	12.45%	❌

benedeki · 2023-08-16T09:46:56Z

RELEASE.md

@@ -0,0 +1,23 @@
+# Release


Please add the reference to this file into README.md like we have it in other libs

benedeki · 2023-08-16T09:53:04Z

build.sbt

  )
  .enablePlugins(TomcatPlugin)
  .enablePlugins(AutomateHeaderPlugin)
+  .jvmPlatform(scalaVersions = Seq(scala212))


Good for now. 2.13 should be added eventually too.

benedeki · 2023-08-16T09:56:12Z

project/plugins.sbt

+addSbtPlugin("za.co.absa.sbt" % "sbt-jacoco" % "3.4.1-absa.4" from "https://github.com/AbsaOSS/sbt-jacoco/releases/download/3.4.1-absa.4/sbt-jacoco-3.4.1-absa.4.jar")
+addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2")
+
+// To add release plugin


Please add this above the JaCoco plugins block. It's kind of lost here.

… file

benedeki

Nice, about the extra part of code coverage 😎

TebaleloS added 5 commits July 20, 2023 15:11

fixes #63 - added some configs variables for stb and jacoco code cove…

2d21203

…rage.

fixes #63 - added more configs variables for stb

14d646d

fixes #63 - added GitHub workflow Actions

3eb3bc2

fixes #63 - added license

6ce13a7

fixes #63

477668c

TebaleloS self-assigned this Jul 21, 2023

TebaleloS and others added 2 commits July 21, 2023 12:39

fixes #63

b5eeb81

* Fixed ProjectMatrix

5e515f4

benedeki mentioned this pull request Jul 24, 2023

#56: Add common project workflows #62

Merged

benedeki and others added 8 commits July 25, 2023 12:54

* fixed bugs preventing project load and compilation

baf028e

Fixes #63 - Emplementing jacoco setup

4986ee3

Fixes #63 - implementing jacoco setup

5b45f64

Fixes #63 - implementing jacoco setup

51b9e1c

Fixes #63 - implementing jacoco setup

15e9cda

Fixes #63 - Fixing license

cad07a8

Fixes #63 - Fixing license

6f28029

Fixes #63 - removed license_check and CODEOWNERS files

f857c6c

TebaleloS marked this pull request as ready for review July 26, 2023 10:19

benedeki requested review from benedeki, Zejnilovic, lsulak and miroslavpojer July 26, 2023 12:23

miroslavpojer reviewed Jul 27, 2023

View reviewed changes

benedeki reviewed Jul 28, 2023

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

version.sbt Outdated Show resolved Hide resolved

project/plugins.sbt Show resolved Hide resolved

TebaleloS and others added 5 commits July 28, 2023 15:27

Update project/plugins.sbt

4fc19ad

Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>

Update project/plugins.sbt

0613062

Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>

Fixes #63 - Added jacoco workflow

7d8e344

Merge remote-tracking branch 'origin/feature/#63-Create-build-matrix-…

7b27dd1

…and-build-action' into feature/#63-Create-build-matrix-and-build-action

Fixes #63 - Added dependent_items.yml

74f762f

TebaleloS added 4 commits August 3, 2023 17:55

Fixes #63 - update build.sbt

a67dade

Fixes #63 - update publish.sbt

ff74223

Merge remote-tracking branch 'origin/feature/#63-Create-build-matrix-…

33f3a40

…and-build-action' into feature/#63-Create-build-matrix-and-build-action

Fixes #63 - update publish.sbt

a071931

Fixes #63

69540df

lsulak reviewed Aug 7, 2023

View reviewed changes

.github/workflows/license_check.yml Outdated Show resolved Hide resolved

lsulak reviewed Aug 7, 2023

View reviewed changes

.github/workflows/jacoco_check.yml Outdated Show resolved Hide resolved

lsulak reviewed Aug 7, 2023

View reviewed changes

.github/workflows/jacoco_check.yml Outdated Show resolved Hide resolved

lsulak reviewed Aug 7, 2023

View reviewed changes

.github/workflows/jacoco_check.yml Outdated Show resolved Hide resolved

TebaleloS added 2 commits August 8, 2023 10:35

Fixes #63

064ab03

Fixes #63

fdb86e3

TebaleloS added 2 commits August 9, 2023 21:41

Fixes #63

d244a4b

Closes #63

723246d

benedeki reviewed Aug 16, 2023

View reviewed changes

Closes #63 - Added notes for jacoco coverage and realse in the readme…

26c3506

… file

benedeki approved these changes Aug 16, 2023

View reviewed changes

TebaleloS merged commit 1bcaa3d into master Aug 16, 2023
4 of 5 checks passed

TebaleloS deleted the feature/#63-Create-build-matrix-and-build-action branch August 16, 2023 11:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/#63 create build matrix and build action #64

Feature/#63 create build matrix and build action #64

TebaleloS commented Jul 21, 2023 •

edited

Loading

miroslavpojer commented Jul 27, 2023 •

edited

Loading

miroslavpojer left a comment •

edited

Loading

miroslavpojer Jul 27, 2023

github-actions bot commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

lsulak Aug 7, 2023

TebaleloS Aug 8, 2023 •

edited

Loading

benedeki Aug 16, 2023

github-actions bot commented Aug 8, 2023

github-actions bot commented Aug 8, 2023

benedeki Aug 16, 2023

benedeki Aug 16, 2023

benedeki Aug 16, 2023

benedeki left a comment

Feature/#63 create build matrix and build action #64

Feature/#63 create build matrix and build action #64

Conversation

TebaleloS commented Jul 21, 2023 • edited Loading

Notes

miroslavpojer commented Jul 27, 2023 • edited Loading

miroslavpojer left a comment • edited Loading

Choose a reason for hiding this comment

miroslavpojer Jul 27, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 3, 2023

JaCoCo server module code coverage report - scala 2.12.12

github-actions bot commented Aug 3, 2023

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

github-actions bot commented Aug 3, 2023

JaCoCo server module code coverage report - scala 2.12.12

github-actions bot commented Aug 4, 2023

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

github-actions bot commented Aug 4, 2023

JaCoCo server module code coverage report - scala 2.12.12

github-actions bot commented Aug 4, 2023

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

github-actions bot commented Aug 4, 2023

JaCoCo server module code coverage report - scala 2.12.12

github-actions bot commented Aug 4, 2023

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

github-actions bot commented Aug 4, 2023

JaCoCo server module code coverage report - scala 2.12.12

lsulak Aug 7, 2023

Choose a reason for hiding this comment

TebaleloS Aug 8, 2023 • edited Loading

Choose a reason for hiding this comment

benedeki Aug 16, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 8, 2023

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

github-actions bot commented Aug 8, 2023

JaCoCo server module code coverage report - scala 2.12.12

benedeki Aug 16, 2023

Choose a reason for hiding this comment

benedeki Aug 16, 2023

Choose a reason for hiding this comment

benedeki Aug 16, 2023

Choose a reason for hiding this comment

benedeki left a comment

Choose a reason for hiding this comment

TebaleloS commented Jul 21, 2023 •

edited

Loading

miroslavpojer commented Jul 27, 2023 •

edited

Loading

miroslavpojer left a comment •

edited

Loading

TebaleloS Aug 8, 2023 •

edited

Loading