Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the server executable: #51 #66

Merged
merged 16 commits into from
Sep 21, 2023
Merged

make the server executable: #51 #66

merged 16 commits into from
Sep 21, 2023

Conversation

TebaleloS
Copy link
Collaborator

@TebaleloS TebaleloS commented Aug 17, 2023 •
edited by benedeki
Loading

##Build Server Module as a war file

*Added config for building a server module as a war file

Closes #51

@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

JaCoCo agent module code coverage report - spark:2 - scala 2.12.12

There is no coverage information present for the Files changed

Total Project Coverage 65.64% ❌

@github-actions
Copy link

JaCoCo server module code coverage report - scala 2.12.12

There is no coverage information present for the Files changed

Total Project Coverage 12.45% ❌

@TebaleloS TebaleloS self-assigned this Aug 17, 2023
@TebaleloS TebaleloS marked this pull request as ready for review August 17, 2023 14:08
lsulak
lsulak reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good so far, please add a few simple instructions about this into README :)

lsulak
lsulak approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the docs, feel free to review. Approved from my side

@TebaleloS TebaleloS merged commit 9d648f9 into master Sep 21, 2023
4 of 5 checks passed
@TebaleloS TebaleloS deleted the feature/#51-Make-the-server-executable branch September 21, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsulak lsulak lsulak approved these changes

@benedeki benedeki Awaiting requested review from benedeki benedeki is a code owner

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

Assignees

@TebaleloS TebaleloS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the server executable
2 participants
@TebaleloS @lsulak