Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Private Content page, invalid link #213

Closed
1 task done
kallie-e opened this issue Nov 14, 2023 · 2 comments · Fixed by #214
Closed
1 task done

On Private Content page, invalid link #213

kallie-e opened this issue Nov 14, 2023 · 2 comments · Fixed by #214
Assignees
Labels
editorial Typo and grammar fixes or minor rewrites to correct inaccuracies

Comments

@kallie-e
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Which topic?

https://developer.adobe.com/commerce/php/development/cache/page/private-content/#cacheable-page-checklist

What's wrong with the content?

Under "Cacheable page checklist", the last bullet point, the link to "context variable" navigates to "Error 404: Page not found"

What changes do you propose?

Update the url to the appropriate existing page that discusses declaring a custom context variable.

I think this might be this link. Please verify first:
https://developer.adobe.com/commerce/php/development/cache/page/public-content/#configure-page-variations

Anything else that can help to cover this?

Not that I can think of.

@jeff-matthews
Copy link
Contributor

Thanks for the report @kallie-e!

You're right, the link should be: https://developer.adobe.com/commerce/php/development/cache/page/public-content/#configure-page-variations

Do you want to open a pull request to update that?

@jeff-matthews jeff-matthews added the editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Nov 14, 2023
@jeff-matthews jeff-matthews self-assigned this Nov 21, 2023
jeff-matthews added a commit that referenced this issue Nov 21, 2023
@jeff-matthews
Copy link
Contributor

Since the fix is a little nuanced, I decided to open a PR.

Note to self/team: You must use absolute links within include files.

jeff-matthews added a commit that referenced this issue Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants