Allow .NET Library to send encrypted payloads to the /sync and /async Cloud Terminal API endpoints
#1060
Conversation
…ndpoints Split CloudTerminalApi into a /sync and /async service, to avoid confusion with the '-Async` (csharp) suffix for asynchronous functions.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| : base(client) | ||
| { | ||
| // Set default server certificate validation to true so no certificate check is performed | ||
| var handler = new HttpClientHandler { ServerCertificateCustomValidationCallback = (message, certificate2, arg3, arg4) => true }; | ||
| HttpClientHandler handler = new HttpClientHandler { ServerCertificateCustomValidationCallback = (message, certificate2, arg3, arg4) => true }; |
Check failure
Code scanning / SonarCloud
Server certificates should be verified during SSL/TLS connections
|
Also for most services in the lib we provide a non async method by awaiting the async methods task. It's a bit trivial for most .NET developers but maybe nice to have. |
There was a problem hiding this comment.
@jillingk Also for most services in the lib we provide a non async method by awaiting the async methods task. It's a bit trivial for most .NET developers but maybe nice to have.
I'll add the functionality and add the HttpClient.Request(...) synchronous calls as well
@jillingk @wboereboom I noticed that with these changes, we'd be breaking the library. Should I can reintroduce the previous name of the class, mark it as [Obsolete] & point it to the new function? That way, we don't introduce a breaking change, what do you think?
Hmm yeah we just did a major. Maybe good to make it non breaking for now and add the tag that we will remove the old stuff next major release |
|
I'm also all for a Deprecation strategy with a softer landing. Might be good to already plan when you actually want to remove the old stuff. We could also communicate this to our community so they know what to expect. |
|
I'll modify the PR and apply a non-breaking change fix next tuesday |
Allow client to send encrypted synchronous requests
|
Description
Allows developers to send encrypted payloads using the Terminal Cloud API (
/sync&/asyncendpoints)Fixed issue:
#995
Changes:
/async-endpoint/sync-endpointhttps://198.51.100.1:8443/nexo)Adyen/Service/Resource/Terminal/TerminalApi.cshas been removed/refactored into; it simply contained the endpoint nameAdyen/Service/TerminalCloudApi.csas[Obsolete], developers should use one of the three service-classes above insteadTerminalRequestAsynchronousAsync(...),TerminalRequestSynchronousAsync(...),TerminalRequestAsync(...),TerminalRequestSync(...)were confusing because of the name of the endpoints, I've split the two concerns:/async&/syncinto the respective servicesFixes:
RequestAsync(...)is called, previously it only would return the response whenRequest(...)is calledAdyen/ApiSerialization/SaleToPoiMessageSecuredSerializer.csis now markedpublic, developers can use this class when neededBreaking change:
[Obsolete]and mentioned the name of the new to the new class