Fix crash: duplicate items when rendering payment methods list #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmamont
added
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
erenbesel
previously approved these changes
Sep 27, 2024
goergisn
previously approved these changes
Sep 27, 2024
nauaros
previously approved these changes
Sep 27, 2024
atmamont
dismissed stale reviews from nauaros, goergisn, erenbesel, and GitHub Actions
via
2a2a3d7
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
|
goergisn
approved these changes
Sep 27, 2024
atmamont
deleted the
bugfix/fix-diffabledatasource-crash-in-payment-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
iOS18 release introduced new crash which didn't happen before.
When rendering payments list, in rare occasions we could have multiple payment methods having same title and description.
Providing ListItem that is used to render the list uses title as part of it's
HashableandEquatableconformance, resulting in having two identical entries.This list typically has few sections: stored payment methods and generic payment methods. While any stored payment method always has an unique identifier coming from the backend, the rest of the sections do not.
That's why this fix does not use any backend-provided identifiers and relies purely on
UUIDthat is created uponListIteminstantiation and doesn't get exposed anywhere else.It can be improved by providing a parameter in the init so it could be injected from the outside.
Note:
ListItemhasidentifierproperty that can be mistreated easily and abused. We use it so set an identifier that is later used asaccessibilityIdentifierfor UI elements. This is misleading as for such a case when we have two identical stored payment methods this could be a potential accessibility problem that will make second duped element on the list inaccessible.Screenshot
COIOS-797