-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack overflow #2
Comments
Hi @dvtomas, with your nmea I got such error "Unknown or implemented sentence type: GNS at line 2", Can you provide some details, like type of CPU, version of rustc and stack trace? |
Hi, cargo run gives me
If you need more details, please just ask me. |
Hi @dvtomas , thank you for the way to reproduce problem. |
@dvtomas, I fix it in master. I plan to add support for unknown messages in your log, |
Ok, I just tried latest master and it seems to work fine. Thank you for your effort. I see you have pasted my code as a test. I think it would be better to remove the println and eprintln statements (ad262f2#diff-e2a8b794872705e1e70d1fbbf4ddd028R48 and ad262f2#diff-e2a8b794872705e1e70d1fbbf4ddd028R52) so not to clutter the test output. If you want to assert creating the debug string doesn't recurse indefinitely, I think just performing a |
From maintainer point of view |
Hmm, my cargo test doesn't supress the output, instead it prints stuff like
If this was interspersed with loads of print! output, I would have a hard time checking which tests went ok and which not. When I need more helpful assertions, I use the extended assert! version: #[test]
fn test_assert() {
let x = 1;
let y = 2;
assert!(x == y, "X and Y don't equal, x: {}, y: {}", x, y);
} outputs on cargo test
That is not to say I want to impose my way of working on you, I understand you may like yours more. I just wanted to share what works well for me. As a user, I'm happy with rust-nmea the way it is now. |
One more tip: A couple of months ago I discovered the pretty-assertions crate, that's been very helpful to me! I'm not sure if you're aware of it. |
functional_tests - improve readability and use vec & no_std attribute
Hi,
nmea 0.0.7 chokes with Stack Overflow on this data dumped from the GPS integrated into the Algiz tablet:
The text was updated successfully, but these errors were encountered: