Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locking the image orientation in the rephotography view #1

Open
puik opened this issue Jan 6, 2022 · 2 comments
Open

locking the image orientation in the rephotography view #1

puik opened this issue Jan 6, 2022 · 2 comments

Comments

@puik
Copy link
Member

puik commented Jan 6, 2022

Complexity estimation: ?

Description:
The rephotography view does not need to be responsive but rather the image orientation should be locked in order to best use the camera (sensor orientation) – if the historic picture is in landscape orientation then the picture should be laid on the screen longer side on the device's longer side forcing the user to rotate the device in hand.
Responsiveness allowed only 180 degrees

Acceptance criteria:
When rephotographing view is opened the picture is displayed with best fitting on the screen (as in the existing android application).

We want this by default:
Screenshot_20220106-130125.jpg

And we don't need this:
Screenshot_20220106-130101.jpg

@puik puik added this to the Rephotography functionality milestone Jan 6, 2022
@puik
Copy link
Member Author

puik commented Jan 6, 2022

@zache-fi and @henwhy can you comment on that?
I know that we've mentioned this issue in conversations but what the complexity here?

@zache-fi
Copy link
Contributor

Partially done, but requires still review that which orientation it should be locking as it depends on devices if the lock position should be mirrored. (ie. in some devices it is upside-down)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants