Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using AliRoot utilities? #3

Open
ginnocen opened this issue Aug 23, 2020 · 4 comments
Open

Using AliRoot utilities? #3

ginnocen opened this issue Aug 23, 2020 · 4 comments

Comments

@ginnocen
Copy link
Contributor

ginnocen commented Aug 23, 2020

@preghenella. In the O2 converter for Run3 we are currently using some utilities from AliRoot for performing some truncation (AliMathBase::TruncateFloatFraction). I didn't use them for the moment cause I was not sure we wanted to go in that direction. I temporary removed the truncation. I wanted to know what you think about it.
I still have to check that the absence of truncation has the only effect of making the dataset bigger as I expect.

@preghenella
Copy link
Collaborator

As discussed with Peter, we will copy the piece of code from Aliroot for the truncation.

I would possibly avoid to link this package to Aliroot because it would need Aliroot built with o2 defaults and available on Grid

@preghenella
Copy link
Collaborator

The truncation code can be put in the converter.h

@ginnocen
Copy link
Contributor Author

OK I can take care of it today.

@preghenella
Copy link
Collaborator

@ginnocen
is this issue still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants