Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Browsing bug result from accessibility tree #5615

Open
1 task done
yufansong opened this issue Dec 15, 2024 · 6 comments
Open
1 task done

[Bug]: Browsing bug result from accessibility tree #5615

yufansong opened this issue Dec 15, 2024 · 6 comments
Assignees
Labels
browser Related to the Browser agent in OpenHands bug Something isn't working

Comments

@yufansong
Copy link
Collaborator

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

The "x" button on the top right corner doesn't show up in the accessibility tree, so agents has a hard time closing this layover.
The following image come from the owncloud service.

image image

OpenHands Installation

Docker command in README

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

@yufansong yufansong added the bug Something isn't working label Dec 15, 2024
@ryanhoangt
Copy link
Contributor

I can have a 👀 at the browsergym to see if we can raise a PR to fix it.

@ryanhoangt
Copy link
Contributor

ryanhoangt commented Dec 26, 2024

I looked into this issue, and it seems to me like a bug from the owncloud service. Below is the HTML from the modal, where the <a> tag misses the href attribute (which should be set to "#"). This causes the ax tree to use a generic node role for that close button (id 821) instead of a clickable link.

Screenshot 2024-12-27 at 00 43 44

We may need to raise an issue for the owncloud repo to fix it.

@yufansong
Copy link
Collaborator Author

Get it. Thanks for the investigation!

@li-boxuan
Copy link
Collaborator

@ryanhoangt Great finding! I still have a doubt: per this standard an a tag without a href attribute is still valid, and it doesn't seem to be an uncommon usage: https://stackoverflow.com/questions/10510191/valid-to-use-a-anchor-tag-without-href-attribute

I'd say browsergym should treat all a tags as clickable.

@mamoodi mamoodi added the browser Related to the Browser agent in OpenHands label Dec 27, 2024
@ryanhoangt
Copy link
Contributor

ryanhoangt commented Dec 28, 2024

Actually I see if the <a> tag misses the href attribute, the accessibility tree returned by the browser will use the generic node type. Browsergym just does the transformation job on that axtree and makes it available to the agent I think.

Screenshot 2024-12-27 at 00 49 04

@li-boxuan
Copy link
Collaborator

li-boxuan commented Dec 28, 2024

Actually I see if the <a> tag misses the href attribute, the accessibility tree returned by the browser will use the generic node type. Browsergym just does the transformation job on that axtree and makes it available to the agent I think.

Screenshot 2024-12-27 at 00 49 04

Thanks, I guess we could say it's a limitation of accessibility tree approach then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Related to the Browser agent in OpenHands bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants