Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to editor page #4003

Open
Alex-developer opened this issue Dec 1, 2024 · 2 comments
Open

Changes to editor page #4003

Alex-developer opened this issue Dec 1, 2024 · 2 comments
Assignees
Labels
enhancement In testing Change being tested by the Allsky team

Comments

@Alex-developer
Copy link
Collaborator

If this is a new feature, describe what you would like.

Few changes to the page

  1. Validate json config in editor before saving as its possible to save invalid json
  2. Remove the 'xxx saved' messages as they just build up if you save the config over and over
  3. Change the save alert to something a little more friendly
@Alex-developer Alex-developer added this to the v2024.12.06_01 milestone Dec 1, 2024
@Alex-developer Alex-developer self-assigned this Dec 1, 2024
@EricClaeys
Copy link
Collaborator

@Alex-developer,
For # 2, is there a way to display a message that goes away when the user presses "Save"? That would allow us to keep the message and not have them build up.

Thanks for entering this.

@Alex-developer Alex-developer added the In progress Change in progress label Dec 21, 2024
Alex-developer added a commit that referenced this issue Dec 22, 2024
Alex-developer added a commit that referenced this issue Dec 22, 2024
Alex-developer added a commit that referenced this issue Dec 22, 2024
@Alex-developer
Copy link
Collaborator Author

Changes made

  1. Upgraded Codemirror to latest version
  • Includes line numbers
  • Adds lint option
  1. Added lint option for json files (Shows errors on editor)
  2. Changed message when no files available to edit
  3. Validate the json data before its saved to prevent invalid config files from being saved
  4. Removed the 'are you sure you want to save' prompt as its pointless
  5. Added overlay when saving, the remote config save takes a little while so this gives the user some feedback
  6. For not fatal errors the 'saved ok' message is removed after 2 seconds
  7. When files are loaded 'XX_NEED_TO_UPDATE_XX' is auto highlighted
  8. cleaned up a few minor bits of code

@Alex-developer Alex-developer added In testing Change being tested by the Allsky team and removed In progress Change in progress labels Dec 22, 2024
Alex-developer added a commit that referenced this issue Dec 22, 2024
Alex-developer added a commit that referenced this issue Dec 22, 2024
#4003 Make XX_NEED_TO_UPDATE_XX a defined variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement In testing Change being tested by the Allsky team
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants