Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hugo to latest version #712

Open
codyro opened this issue Dec 12, 2024 · 2 comments
Open

Update Hugo to latest version #712

codyro opened this issue Dec 12, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@codyro
Copy link
Member

codyro commented Dec 12, 2024

We pin Hugo to 0.98.0, while the latest version is 0.139.4. There have been a ton of QoL improvements, which we could and should leverage.

All that needs to be done for this is to verify that the site builds and runs cleanly (look for Hugo warnings and errors). If it doesn't, we'll want to fix whatever is wrong (EX, deprecated functions, etc.).

After that someone from the Infrastructure will verify everything and update the CloudFlare Pages version (HUGO_VERSION environmental).

Further context:
#709 (comment)

@codyro codyro added enhancement New feature or request good first issue Good for newcomers labels Dec 12, 2024
@alaurie
Copy link

alaurie commented Dec 19, 2024

I think the current build process is pulling the latest version regardless of any pinning done.

https://github.com/AlmaLinux/almalinux.org/actions/runs/12401185107/job/34620009233

image

@codyro codyro self-assigned this Dec 19, 2024
@codyro
Copy link
Member Author

codyro commented Dec 19, 2024

I think the current build process is pulling the latest version regardless of any pinning done.

https://github.com/AlmaLinux/almalinux.org/actions/runs/12401185107/job/34620009233

image

Whoopsie doodle. You're right! I forgot we changed how we published the website a while ago, making that environmental variable unused.

For some context, we use Cloudflare Pages to serve the website. Previously, we had the website cloned and built on their end (https://developers.cloudflare.com/pages/framework-guides/deploy-a-hugo-site/#use-a-specific-or-newer-hugo-version). However, at some point, we needed to work around some gotcha and ended up using a GitHub action to build the website via a GH runner and then upload it to Cloudflare Pages. It looks like we never pinned a version in that action: https://github.com/AlmaLinux/almalinux.org/blob/master/.github/workflows/publish.yml#L21-L24

@jonathanspw We should consider pinning to a version to avoid accidentally pushing a broken version of the site unexpectedly. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants