ThunderboltIoc source generator currupting dictionary and burning CPU cores

[davkean]

Folks, I'm from the Visual Studio performance and reliability team, and we've caught an issue via our telemetry where ThunderboltIoc source generators are entering an infinite loop on the following path:

microsoft.codeanalysis.dll!Microsoft.CodeAnalysis.GeneratorDriver.RunGenerators | 100%
microsoft.codeanalysis.dll!Microsoft.CodeAnalysis.GeneratorDriver.RunGeneratorsCore | 100%
microsoft.codeanalysis.dll!Microsoft.CodeAnalysis.GeneratorDriver.UpdateOutputs | 100%
microsoft.codeanalysis.dll!Microsoft.CodeAnalysis.SourceOutputNode`[System.__Canon].AppendOutputs | 100%
microsoft.codeanalysis.dll!Microsoft.CodeAnalysis.DriverStateTable+Builder.GetLatestStateTableForNode[System.ValueTuple`[System.__Canon,System.__Canon]] | 100%
microsoft.codeanalysis.dll!Microsoft.CodeAnalysis.SourceOutputNode`[System.__Canon].UpdateStateTable | 100%
microsoft.codeanalysis.dll!Microsoft.CodeAnalysis.UserFunctionExtensions+<>c__DisplayClass_0`[Microsoft.CodeAnalysis.SourceProductionContext,System.__Canon].<WrapUserAction>b__ | 100%
microsoft.codeanalysis.dll!Microsoft.CodeAnalysis.SourceGeneratorAdaptor.<Initialize>b___ | 100%
thunderboltioc.sourcegenerators.dll!ThunderboltIoc.SourceGenerators.ThunderboltSourceGenerator.Execute | 100%
system.core.dll!System.Collections.Generic.HashSet`[System.__Canon]..ctor | 100%
system.core.dll!System.Collections.Generic.HashSet`[System.__Canon].UnionWith | 100%
system.core.dll!System.Collections.Generic.HashSet`[System.__Canon].AddIfNotPresent | 100%
system.core.dll!System.Collections.Generic.HashSet`[System.__Canon].InternalGetHashCode | 100%
thunderboltioc.sourcegenerators.dll!ThunderboltIoc.SourceGenerators.MethodDefinitionEqualityComparer.GetHashCode | 100%
thunderboltioc.sourcegenerators.dll!ThunderboltIoc.SourceGenerators.RoslynSemanticExtensions.GetMethodFullName | 100%
thunderboltioc.sourcegenerators.dll!ThunderboltIoc.SourceGenerators.RoslynSemanticExtensions.MethodCache | 100%
mscorlib.dll!System.Collections.Generic.Dictionary`[System.__Canon,System.__Canon].Insert

This is occuring due to overlapping read/write from multiple threads in the following method, you can see what's happening described here: https://frugalcafe.beehiiv.com/p/selfinflicted-dos-attack-dictionary-corruption. Please move to a ConcurrentDictionary to avoid this.

https://github.com/AlyElhaddad/ThunderboltIoc/blob/ec72a9de19668036515d5ffbade9bc208bdc8291/src/ThunderboltIoc.SourceGenerators/RoslynSemanticExtensions.cs#L10-L17z