delete void* is ill-formed

[ycraurora]

In the file cyber/transport/shm/protobuf_arena_manager.cc, a delete void* operation is performed. However, as void* is a pointer to a template class ArenaQueue and not a primitive value type, the destructor ~ArenaQueue() will not be invoked upon deletion of the map value.

The code

[hearto1314]

Hi @ycraurora , Thanks for your issue, it seems a real bug.
ArenaQueue is only used to optimize lidar drivers currently, and ProtobufArenaManager has been DECLARE_SINGLETON, caused the problem is not fully exposed, we will verify this issue later.

[ycraurora]

Hi @ycraurora , Thanks for your issue, it seems a real bug. ArenaQueue is only used to optimize lidar drivers currently, and ProtobufArenaManager has been DECLARE_SINGLETON, caused the problem is not fully exposed, we will verify this issue later.

Thanks for your reply. Since deleting a void* is undefined behavior, clangd can catch this error with the message "Cannot delete expression with pointer-to-'void' type 'void *'clang(-Wdelete-incomplete)".
BTW, a simple way to fix this is to use std::shared_ptr<void> instead of void*. You may want to check it out.