Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings when compiling #23

Open
ohadnav opened this issue Mar 7, 2018 · 3 comments
Open

Warnings when compiling #23

ohadnav opened this issue Mar 7, 2018 · 3 comments

Comments

@ohadnav
Copy link

ohadnav commented Mar 7, 2018

Compilation warnings encountered:

StringUtil.sol:250:5: Warning: This declaration shadows an existing declaration.
    uint len;
    ^------^
StringUtil.sol:157:3: The shadowed declaration is here:
  function len(slice self) internal returns (uint l) {
  ^
Spanning multiple lines.



StringUtil.sol:250:5: Warning: This declaration shadows an existing declaration.
    uint len;
    ^------^
StringUtil.sol:157:3: The shadowed declaration is here:
  function len(slice self) internal returns (uint l) {
  ^

Solidity: 0.4.18
Compiler: Truffle 4.0.7

@ohadnav
Copy link
Author

ohadnav commented Mar 7, 2018

Also..

StringUtil.sol:474:11: Warning: Jump instructions are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using "switch" or "for" statements instead.
          jumpi(exit, eq(and(mload(ptr), mask), needledata))
          ^---^

@axic
Copy link
Contributor

axic commented Jul 23, 2018

The len problem was fixed by #17. The rest by #25.

@PatrickAlphaC
Copy link

Any movement on these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants