-
Notifications
You must be signed in to change notification settings - Fork 17.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copter: NAV_LOITER_TURNS Broken on 4.1.0-DEV #17126
Comments
I can reproduce the issue |
Great, thanks for the report. I've added this to the 4.1 issues list (#16478) so it won't be forgotten. |
Oddly enough it worked in real life but it is broken on SITL at least for me and @shellixyz |
thanks again for this report and I've got a fix now I think. maybe you could give it a try when you get a second? The problem only happened if lat,lon,alt were specified so perhaps that's why it only happened in SITL. |
My pleasure @rmackay9 ! It seems to work fine on SITL now. Will fly test it as soon weather allows. Thanks again for this prompt fix! |
fixed in master, thanks for the report and testing! |
Bug report
NAV_LOITER_TURNS WP type doesn't work on master with default params.
The copter reaches the WP and waits there forever without starting to circle.
I've tracked down the issue in the fact that the navigation gets "stuck" inside the function:
bool ModeAuto::verify_circle(const AP_Mission::Mission_Command& cmd)
with copter.wp_nav->reached_wp_destination() being false.
working revision: 67f2c79 before the SCURVES PR
broken behaviour on master:
Waypoint file to test with
way.txt
Platform
[ ] All
[ ] AntennaTracker
[ x ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine
I think @rmackay9 @lthall and @IamPete1 can have a say on this
The text was updated successfully, but these errors were encountered: