Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank and silent time frame is added after convert to mp3 #5

Open
MattAtRiversoft opened this issue Sep 21, 2014 · 11 comments
Open

blank and silent time frame is added after convert to mp3 #5

MattAtRiversoft opened this issue Sep 21, 2014 · 11 comments

Comments

@MattAtRiversoft
Copy link

For example I record 10 seconds, after converted to mp3, it will get extra 10 blank second.

@vipul-mishra-zz
Copy link

Same issue here.. Any luck anyone..???

@ashishpuliyel
Copy link

+1 on this issue. If anyone has a solution, please share it.

@miwels
Copy link

miwels commented Nov 5, 2014

Had the same issue and because of the fact that the author doesn't reply here is my solution:

Open js/libmp3lame.min.js
Find the following line (nearly at the bottom)

a=Module.ccall("lame_encode_buffer_ieee_float","number","number number number number number number".split(" "),
[a,c,g,b.length,f,1024E3]);

And replace it with:

a=Module.ccall("lame_encode_buffer_ieee_float","number","number number number number number number".split(" "),
[a,c,g,b.length/2,f,1024E3]);

(As you can see, the only difference is that b.length becomes b.length/2)

I've tested it and the plugin doesn't add extra time any more and it converts to mp3 without problem.

Regards

@ashishpuliyel
Copy link

Thanks @miwels - that works for me as well.

@BondaCB
Copy link

BondaCB commented Nov 19, 2014

Worked, thanks @miwels

@geirman
Copy link

geirman commented Dec 6, 2014

Thanks @miwels, worked for me too!

@fdulger
Copy link

fdulger commented Jan 20, 2015

Thanks @miwels!

@circuitrider
Copy link

This fix isn't working for me in Firefox 37.0.1 at least.

@ScottCrass
Copy link

Also doesn't work for me in chrome 42.0.2311.135

@geirman
Copy link

geirman commented May 12, 2015

try my forked version. I've not tested on firefox, but it definitely works on chrome. https://github.com/geirman/recorder-wav-mp3

@ScottCrass
Copy link

Ah there we go, thanks for working on this. Super handy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants