Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrals - Update strings for translations #2941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Sep 27, 2024

Description

This updates referral strings (for dynamic duration) for translations before the 7.74 code-freeze.

Testing Instructions

Screenshots or Screencast

ToolTip FVJPaWlRMlosEpsRhqxnSD-fi-2189_9583 Send Pass FVJPaWlRMlosEpsRhqxnSD-fi-2189_9583 Claim Pass Banner FVJPaWlRMlosEpsRhqxnSD-fi-2189_8773 Claim Pass Page FVJPaWlRMlosEpsRhqxnSD-fi-2189_8613 Share Text FVJPaWlRMlosEpsRhqxnSD-fi-2189_9583
tooltip send_pass banner claim_pass email_2

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the Future milestone Sep 27, 2024
@ashiagr ashiagr requested a review from a team as a code owner September 27, 2024 06:41
@ashiagr ashiagr requested review from MiSikora and removed request for a team September 27, 2024 06:41
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 27, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit49441a0
Direct Downloadpocketcasts-app-prototype-build-pr2941-49441a0.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit49441a0
Direct Downloadpocketcasts-automotive-prototype-build-pr2941-49441a0.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit49441a0
Direct Downloadpocketcasts-wear-prototype-build-pr2941-49441a0.apk

@@ -0,0 +1,13 @@
package au.com.shiftyjelly.pocketcasts.models.type

interface ReferralsOfferInfo {
Copy link
Contributor Author

@ashiagr ashiagr Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches iOS class.

Mock data class used in displays will be replaced with data from Play Store offer in a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants