Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not calculate coverage on external PRs #2123

Merged

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Oct 21, 2024

resolves #2118

Execute coverage only if pull_request.base.repo.full_name == pull_request.head.repo.full_name

Any other place where this should be tested ?

@FredLL-Avaiga FredLL-Avaiga added Core Related to Taipy Core 📈 Improvement Improvement of a feature. 🖧 Devops Operations, monitoring, maintenance, deployment, packaging 🖰 GUI Related to GUI 🟧 Priority: High Must be addressed as soon labels Oct 21, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19121 16578 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: d376a13 by action🐍

Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better than failing. For sure !!

Thanks

@FredLL-Avaiga FredLL-Avaiga merged commit 3c5c915 into develop Oct 22, 2024
8 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#2118-do-not-calculate-coverage-on-external-PR branch October 22, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Taipy Core 🖧 Devops Operations, monitoring, maintenance, deployment, packaging 🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟧 Priority: High Must be addressed as soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow all actions to be performed on a PR from external contributor
3 participants