-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MsExtensionsHostingSample sample project #64
base: main
Are you sure you want to change the base?
Conversation
I have been using this branch as a basis for my IHost usage but struggled when it came to multi views using the I came across some issues understanding how that works with the ViewLocator and the DI registration of MainWindowViewModel only being bound to one View. Not sure if something would need to change a bit with the DI to make a foundation for Windows extensions generic host with a "starting example" for navigation. |
@pjmagee typically you would have two ViewModels for two views where each VM is represented by a DataTemplate. Then if you swap DataContext of your Window, you should be navigated automatically. Check also the NavigationSample (okay it's without DI but concept should be similar) |
ahh, thank you. Checking out now |
Wow what awesome timing for this PR! I just started looking into Avalonia and this was my first question :) Thanks for working on this. @maxkatz6 apart from the "in any case" items, is there anything you consider missing from the sample? |
Why is the |
DesignData class is using it. |
Ahhh thanks for the help, I totally overlooked that... I don't like the dependency though, but I get it for this scenario. |
Might be able to make it private and expose an alternative for the DesignTime and wrap it around some compiler labels so its 'removed' from what would be considered actual runtime code? |
What does the pull request do?
Adds a sample project on how to use .NET Generic Host in a typical Avalonia app.
Scope of this PR:
Checklist
If this is a new Sample
Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with a link to your sample in the related documentation pageIn any case
Fixed issues
Fixes #35