Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow formatting with redhat.vscode-xml #100

Open
BinToss opened this issue Feb 2, 2024 · 2 comments
Open

[Feature] Allow formatting with redhat.vscode-xml #100

BinToss opened this issue Feb 2, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BinToss
Copy link
Contributor

BinToss commented Feb 2, 2024

Note: redhat.vscode-xml's default settings are...not great for XAML and AXAML. Additionally, it lacks many of the rules (e.g. attribute grouping) present in https://github.com/Xavalon/XamlStyler (which was suggested in #44)

Is your feature request related to a problem? Please describe.

It's annoying to switch from AXAML to XML just to format the current document.

Describe the solution you'd like

Luckily, redhat's xml extension allows for a simple solution. The only requirement is that other VSCode extensions which add xml-based languages must add a new property to their to their contributes.
It's not identical to formatting XAML in Visual Studio, but it's getting there. Next, it needs the ability to selectively not split attributes
image

Yes. It's that easy.

xmlFormat.mp4

Describe alternatives you've considered

No response

Additional context

No response

@BinToss BinToss added the enhancement New feature or request label Feb 2, 2024
@BinToss

This comment was marked as outdated.

@BinToss
Copy link
Contributor Author

BinToss commented Feb 4, 2024

BinToss@d21ce1c and BinToss@2fa9389 fulfill this feature request. redhat.vscode-xml is not automatically installed.


VSCode does not allow extensions to recommend other extensions (that could get annoying).
"Optional" extension dependencies can be forced upon the user via the Extension Pack feature.

Option A

Redhat publishes a Node package that allows extensions to recommend other extensions

Option B (recommended)

Publish an extension pack separately. It should include avaloniaui.vscode-avalonia and any other extensions we recommend or soft-depend on (i.e. activate only if already installed and enabled).

@prashantvc prashantvc added the good first issue Good for newcomers label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants