Why are the policy toggle parameters not booleans?

[JustinGrote]

Before I create an issue, I was curious if there was a good reason why these are string with "Yes No" validation rather than just simply booleans.

Enterprise-Scale/docs/reference/contoso/armTemplates/auxiliary/identity.json

Lines 12 to 56 in 38f4f1e

	"denyRdpForIdentity": {
	"type": "string",
	"defaultValue": "No",
	"allowedValues": [
	"Yes",
	"No"
	],
	"metadata": {
	"description": "Select whether policy to deny inbound RDP should be assigned or not."
	}
	},
	"denySubnetWithoutNsgForIdentity": {
	"type": "string",
	"allowedValues": [
	"Yes",
	"No"
	],
	"defaultValue": "No",
	"metadata": {
	"description": "Select whether policy to deny subnet without NSG should be assigned or not."
	}
	},
	"denyPipForIdentity": {
	"type": "string",
	"allowedValues": [
	"Yes",
	"No"
	],
	"defaultValue": "No",
	"metadata": {
	"description": "Select whether policy to deny puplic IP should be assigned or not."
	}
	},
	"enableVmBackupForIdentity": {
	"type": "string",
	"allowedValues": [
	"Yes",
	"No"
	],
	"defaultValue": "No",
	"metadata": {
	"description": "Select whether policy to enable VM backup should be assigned or not."
	}
	}
	},

[jtracey93]

@krnese could you advise here? 👍

I suspect its to do with the portal deployment experience.

[krnese]

Yes, this is for the curated portal experience. What's the issue?

[JustinGrote]

Just seems like this would be better suited with a boolean and a checkbox, but I suppose it comes down to a stylistic choice without being a technical constrant.

https://docs.microsoft.com/en-us/azure/azure-resource-manager/managed-applications/microsoft-common-checkbox?WT.mc_id=Portal-Microsoft_Azure_CreateUIDef

[krnese]

With checkboxes, we would not be able to default to what we would recommend, and require user to explicitly opt-in for the various options we provide.

Further, we would lose some flexibility in terms of how we handle certain conditions if we used bool as type.