Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos DB can use type parameters to simplify inputs #3897

Open
dciborow opened this issue Dec 7, 2024 · 4 comments
Open

Cosmos DB can use type parameters to simplify inputs #3897

dciborow opened this issue Dec 7, 2024 · 4 comments
Assignees
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@dciborow
Copy link
Contributor

dciborow commented Dec 7, 2024

The CosmosDB template can use type parameters that could be imported by users to make it easier to use.

https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/document-db/database-account/main.bicep

Example of how it is done in the mongo db template.

// =============== //
//   Definitions   //
// =============== //

@export()
type secretSetType = {
  @description('The resourceId of the exported secret.')
  secretResourceId: string

  @description('The secret URI of the exported secret.')
  secretUri: string
}

type secretToSetType = {
  @description('Required. The name of the secret to set.')
  name: string

  @description('Required. The value of the secret to set.')
  @secure()
  value: string
}
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Dec 7, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Dec 7, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Dec 12, 2024
@AlexanderSehr
Copy link
Contributor

Hey @seesharprun & @bryansan-msft,
Please triage the issue when you get the chance.
From where I'm standing it makes sense and is a very quick update 🙂

@AlexanderSehr
Copy link
Contributor

Hey @dciborow,
please excuse the late reply. The automatic owner-assignment did not kick in as the issue was not created as a module issue. Highly recommend for the future 😉

@bryansan-msft bryansan-msft added Type: Feature Request ➕ New feature or request and removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants