Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Module Proposal]: avm/ptn/mgmt-groups/subscription-placement #1585

Open
2 tasks done
oZakari opened this issue Oct 22, 2024 · 4 comments · May be fixed by Azure/bicep-registry-modules#3904
Open
2 tasks done

[Module Proposal]: avm/ptn/mgmt-groups/subscription-placement #1585

oZakari opened this issue Oct 22, 2024 · 4 comments · May be fixed by Azure/bicep-registry-modules#3904
Assignees
@oZakari
Labels
Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@oZakari
Copy link
Contributor

oZakari commented Oct 22, 2024 •
edited
Loading

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/mgmt-groups/subscription-placement

Module Details

This module places subscriptions within a specified management group hierarchy. While an example for ALZ (Platform, Landing Zones, Decommissioned, Sandbox, etc.) will be provided in the test cases directory, the module can support any defined hierarchy provided by a user.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

oZakari

(Optional) Secondary Module Owner's GitHub Username (handle)

31Nick
@oZakari oZakari added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Oct 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Oct 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Oct 22, 2024
@oZakari oZakari changed the title [Module Proposal]: avm/lz/subscription-placement [Module Proposal]: avm/ptn/lz/subscription-placement Nov 5, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Pattern Module 📦 This is a pattern module labels Nov 5, 2024
@matebarabas
Copy link
Contributor

Hi @oZakari,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Nov 5, 2024
@oZakari oZakari changed the title [Module Proposal]: avm/ptn/lz/subscription-placement [Module Proposal]: avm/ptn/mgmt-groups/subscription-placement Nov 5, 2024
@oZakari
Copy link
Contributor Author

oZakari commented Nov 6, 2024

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Nov 6, 2024
@matebarabas
Copy link
Contributor

Hi @oZakari,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Nov 12, 2024
@matebarabas matebarabas moved this from Proposed to In development in AVM - Module Triage Nov 12, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

@oZakari, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Dec 4, 2024
@oZakari oZakari linked a pull request Dec 12, 2024 that will close this issue
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oZakari oZakari

Labels
Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
AVM - Module Triage
Status: In development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Sub placement development 31Nick/bicep-registry-modules
2 participants
@matebarabas @oZakari