Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: Hardcoded references to core.windows.net #3947

Open
1 task done
JWHolding opened this issue Dec 17, 2024 · 6 comments · May be fixed by #4041
Open
1 task done

[AVM Module Issue]: Hardcoded references to core.windows.net #3947

JWHolding opened this issue Dec 17, 2024 · 6 comments · May be fixed by #4041
Assignees
@AlexanderSehr
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@JWHolding
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/storage/storage-account

(Optional) Module Version

0.15.0

Description

Module contains hardcoded references to core.windows.net which I believe best practise says this should be ${environment().suffixes.storage}

(Optional) Correlation Id

No response
@JWHolding JWHolding added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Dec 17, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Dec 17, 2024
@avm-team-linter AVM Team Linter
Copy link

@JWHolding, thanks for submitting this issue for the avm/res/storage/storage-account module!

Important

A member of the @Azure/avm-res-storage-storageaccount-module-owners-bicep or @Azure/avm-res-storage-storageaccount-module-contributors-bicep team will review it soon!

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Dec 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Dec 23, 2024
@AlexanderSehr
Copy link
Contributor

Good catch @JWHolding,
I guess you're referring to the two lines:

bicep-registry-modules/avm/res/storage/storage-account/main.bicep

Line 663 in 6439544

value: 'DefaultEndpointsProtocol=https;AccountName=${storageAccount.name};AccountKey=${storageAccount.listKeys().keys[0].value};EndpointSuffix=core.windows.net'

bicep-registry-modules/avm/res/storage/storage-account/main.bicep

Line 679 in 6439544

value: 'DefaultEndpointsProtocol=https;AccountName=${storageAccount.name};AccountKey=${storageAccount.listKeys().keys[1].value};EndpointSuffix=core.windows.net'

Interesting that the linter did not pick up on it 😄

@ktremain, please triage when you get the chance 🚀

@AlexanderSehr AlexanderSehr linked a pull request Dec 23, 2024 that will close this issue
feat: Storage Account - Simplified File Share RBAC assignment to use one less file & a more bicep-native deployment variant #4041
Open
8 tasks
@AlexanderSehr
Copy link
Contributor

Actually nevermind. Impemented it in an already open PR of mine

@AlexanderSehr AlexanderSehr removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Dec 23, 2024
@JWHolding
Copy link
Author

Hi, yes they are the ones! Sorry not to include the line nums!

Strangely enough it's only because we compile to arm and run against the old armttk rulesets that we found it!

Thank for looking!

@jeevankuduvaravindran
Copy link

@AlexanderSehr @ktremain Any update on when this fix would be released? Suffering from the same issue as @JWHolding has mentioned. Compiling bicep to ARM and using ARM TTK throws this error.

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Dec 24, 2024 •
edited
Loading

Hey @jeevankuduvaravindran, the PR is ready. What may be a bit of a challenge is that its Christmas and there's a fair chance e.g. @ktremain is taking some time off. In other words, I wouldn't expect the linked PR to be merged before the new year even though it is just sitting there... I can't approve my own PRs 😄 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderSehr AlexanderSehr

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
AVM - Module Issues
Status: Needs: Triage
Milestone
No milestone
4 participants
@AlexanderSehr @JWHolding @ktremain @jeevankuduvaravindran