Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: Support ACR module reference completions #9038

Open
bhsubra opened this issue Nov 15, 2022 · 8 comments
Open

Investigate: Support ACR module reference completions #9038

bhsubra opened this issue Nov 15, 2022 · 8 comments
Assignees
Labels
devdiv Related to Bicep tooling efforts in DevDiv enhancement New feature or request P1 This is planned to be completed before the end of a release story: registry
Milestone

Comments

@bhsubra
Copy link
Contributor

bhsubra commented Nov 15, 2022

Support ACR module reference completions. Part of #3964

@puicchan
Copy link

puicchan commented May 9, 2024

@StephenWeatherford, let's investigate and document the options here.

@StephenWeatherford StephenWeatherford changed the title Support ACR module reference completions Investigate: Support ACR module reference completions May 10, 2024
@stephaniezyen stephaniezyen modified the milestones: v0.28, v0.29 May 30, 2024
@StephenWeatherford StephenWeatherford modified the milestones: v0.29, v0.30 Jun 25, 2024
@puicchan puicchan modified the milestones: v0.30, v0.31 Jul 9, 2024
@puicchan puicchan added the P1 This is planned to be completed before the end of a release label Aug 5, 2024
@puicchan puicchan modified the milestones: v0.31, v0.32 Sep 10, 2024
@GSerjo
Copy link

GSerjo commented Sep 17, 2024

Could you please clarify. Is auto-completion supposed to work for private registries in VSCode or not? It works fine for public registries but doesn't work for private ones.

image

and no auto-completion for private registry. The module has been detected and works fine, just no auto completion (intellisense)

It looks like this issue relates to it, but I'm not sure. The issue was renamed (initially it was support, now investigate), the milestone has been moved several times. Sorry if it's something else and doesn't relate to auto-completion for private registries.

@StephenWeatherford
Copy link
Contributor

This is definitely something we'd like to do but other priorities have pushed it behind. I'm hoping we can get to it within the next few milestones.

@levimatheri
Copy link
Contributor

levimatheri commented Oct 4, 2024

One other potential enhancement: I noticed if I type a '/' in the registry path, completion is no longer provided (see below) I think it makes sense to make this work similarly to how resource namespace completions work.

playground-1728081800057.mp4

@StephenWeatherford
Copy link
Contributor

Yes, that is definitely annoying, the completions were implemented incorrectly here. Someday hopefully I'll get to fixing that.

@StephenWeatherford
Copy link
Contributor

@levimatheri I'd actually suggest you create a new bug for this, if one doesn't already exist. It's separate to the private ACR completions.

@levimatheri
Copy link
Contributor

Created bug item

@diogocatossi
Copy link

Looking forward for this feature as I'm structuring a global ACR structure for the enterprise and would be great if the development teams could consume it without having to access the Portal to get a list of available modules and their versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devdiv Related to Bicep tooling efforts in DevDiv enhancement New feature or request P1 This is planned to be completed before the end of a release story: registry
Projects
Status: In Progress
Development

No branches or pull requests

7 participants