Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateObject component: should the BHoM_Guid property be exposed? #155

Closed
epignatelli opened this issue Nov 7, 2019 · 5 comments
Closed
Assignees
Labels
type:question Ask for further details or start conversation

Comments

@epignatelli
Copy link
Member

In grasshopper. for instance, there is no way, other of creating a Guid other than scripting.

If we are going to use the Guid as persistent id of the object, should it allowed to be set?

@epignatelli epignatelli added the type:question Ask for further details or start conversation label Nov 7, 2019
@rwemay
Copy link
Member

rwemay commented Nov 7, 2019

Maybe a controversial point, in support of this, but I actually wonder if it should be suppressed by default on explode. Fine to 'get property' as people may want to see/check, but is it necessary in general/typical use-cases? Bearing in mind immutability, is not as if they're tracked in the flow-based programming environment in any case?

@al-fisher
Copy link
Member

I think we should not be exposing or setting Guid (yet) or in its current state.
Agree with Rob - fine to allow GetProperty but -

Ultimately to make more useful and robust for user we need to migrate to the two Guid system with one Persistent. And one referring uniquely to the object instance(s) in the script. This is being looked at in the Deltas work.

I would therefore minimise exposure - on Create or otherwise - currently.

@adecler
Copy link
Member

adecler commented Nov 8, 2019

Ha, and I finally had a case where I was explicitly setting the Guid of the object (in node 2 code) since I needed the Guid of the nodes to match the one of the components. Sure it was in the code and not in the UI but I am never a fan of adding limitations for the sake of it. Too many time I have been frustrated with other developers for preventing me doing something I wanted to do. To 'protect' me they say 🙄

@adecler adecler self-assigned this Sep 25, 2020
@adecler
Copy link
Member

adecler commented Sep 29, 2020

Should be discussed alongside of framework issues such as BHoM/BHoM#784 and BHoM/admin#9

@adecler
Copy link
Member

adecler commented Jan 7, 2023

Will re-open this issue if/once we have user cases justifying to add this feature

@adecler adecler closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Ask for further details or start conversation
Projects
None yet
Development

No branches or pull requests

4 participants