Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding custom languages #678

Open
bitGatito opened this issue Jun 26, 2023 · 3 comments
Open

Adding custom languages #678

bitGatito opened this issue Jun 26, 2023 · 3 comments

Comments

@bitGatito
Copy link

Was experimenting with this repository and it seems that custom BCP-47 language tags cannot be added using private subtags.
@BenjaminVanRyseghem
Copy link
Owner

Do you have a bit more of context? what did you try?

@bitGatito
Copy link
Author

bitGatito commented Jun 27, 2023 •
edited
Loading

I was hoping that BCP-47 privateuse subtags (as well as variant and extension subtags) could be added when defining new languages in the languages folder. For example, it is not possible to add fr-FR-x-franc or x-whatever since validating.js would throw an error the language tag must follow the BCP 47 specification (see https://tools.ieft.org/html/bcp47).

I could open a pull request if you intend to allow privateuse subtags to be added to this library in the future.

@BenjaminVanRyseghem
Copy link
Owner

That looks like a great idea to support them. If you open a PR, I'll be eager to review it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenjaminVanRyseghem @bitGatito