Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in summing "LinOpConv"s with different indices #36

Open
ThomasDeb opened this issue Oct 15, 2021 · 0 comments
Open

Bug in summing "LinOpConv"s with different indices #36

ThomasDeb opened this issue Oct 15, 2021 · 0 comments

Comments

@ThomasDeb
Copy link
Contributor

ThomasDeb commented Oct 15, 2021

I encountered a bug when trying to sum two "LinOpConv" operators whose dimensions along which the convolution is performed do not match. I'm attaching a code snippet illustrating the problem. I don't think it is possible to rewrite this sum as a single convolution operator in the general case, so an easy fix would be to change the "plus_" method of LinOpConv accordingly (from testing isa(G,'LinOpConv') to something like isa(G,'LinOpConv') && isequal(sort(this.index), sort(G.index))). However I'm not sure I fully understand all the subcases of the "plus_" method so I'm not confortable trying to fix the problem completely myself
GlobalBioIm_bug
f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant