Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some coloring inconsistencies in SCSS files #3

Open
smlombardi opened this issue Jun 1, 2016 · 2 comments
Open

some coloring inconsistencies in SCSS files #3

smlombardi opened this issue Jun 1, 2016 · 2 comments

Comments

@smlombardi
Copy link

  • note the first 3 commas on color and the last is white.
  • The alpha value in the rgba color is magenta if it's 0 but green if its something else.
  • hyphenated propetry in transition has a magenta hyphen
  • this is minor and probably not worth it, but the digit in the transition timing is white while other digits in property values are magenta.

screen shot 2016-06-01 at 1 34 34 pm

@Briles
Copy link
Owner

Briles commented Jun 1, 2016

Unfortunately these are a result of improper syntax scoping and would best be fixed by the maintainers of Atom's syntaxes.

  1. the commas should be white, but not all of them are scoped so I can't color them consistently
  2. Certain RGB Alpha values are given an incorrect variable.parameter.url.scss scope. This scope is correctly colored green, but should not be applied in this instance.
  3. The hyphen is scoped as support.constant.mathematical-symbols.scss which is correctly colored as purple, but again, improperly scoped.
  4. Numbers in this case are not given any scope, so I can't color them.

For cases like this I typically mask the improper scoping but for these specific cases I cannot because of the lack of scope specificity.

@smlombardi
Copy link
Author

He has apparently fixed this in langugage-sass: atom/language-sass#152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants