Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp tasks #116

Open
BurkusCat opened this issue Jan 5, 2019 · 5 comments
Open

Update gulp tasks #116

BurkusCat opened this issue Jan 5, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@BurkusCat
Copy link
Owner

  • Gulp tasks no longer live reload properly, need to re-add it back in whilst keeping build non-live reload
  • Scripts gulp task needs to not minify on gulp default and minify in gulp build
@BurkusCat BurkusCat added the bug Something isn't working label Jan 5, 2019
@BurkusCat BurkusCat self-assigned this Jan 5, 2019
@abu271
Copy link
Contributor

abu271 commented Mar 17, 2019

Hey Burkus,

Can I work on this issue?

@bloodywine
Copy link
Collaborator

Hi Abu,

Feel free to work on this issue.

@abu271
Copy link
Contributor

abu271 commented Apr 13, 2019

Hi @BurkusCat @CrayCrayDecay ,

I think I solved the issue the app works fine, so I didn't break anything. I just made minor adjustments to the gulp files.

Thanks,

Abu

@anton-dealmeida
Copy link

Is this still open?

@BurkusCat
Copy link
Owner Author

Yes it is still open, a PR was raised and merged for this but then reverted because it caused a bug on the deployed site: #126

An issue was raised for a bug it caused #127

If you are interested in this issue, you may want to use the original PR as a reference but make sure the output of "gulp build" works as intended (that is what www.r6counters.com uses)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants