return value if deadlocked are detected

[gdesmott]

I'm trying to integrate lockbud (great work btw, thanks a lot!) in our GitLab CI. But according to my tests cargo lockbud -k deadlock stills returns 0 if deadlocks are detected.

Shouldn't it return an error code so the CI can catch it and fail the job?

[BurtonQin]

lockbud may report FPs. I do not know how to return 0 for cargo. But I will look into it.

[gdesmott]

Yes ideally we'll need some way to ignore false positives as well.

I suppose either an annotation in the code or a suppression file as valgrind does.

[BurtonQin]

Fine-grained detection target selection sounds a feasible choice.
I am not quite familiar with github CI.
But here is a project that integrates lockbud and many other detection tools into docker that may be of your help.
https://github.com/os-checker/os-checker

[gdesmott]

https://github.com/os-checker/os-checker

Interesting. From a quick looks it seems they parse the json generated by lockbud. That can make sense if you need to have very fine control on the CI test but I think most people will be happy with returning an error code and having a simple way to discard false positives.