Unique ARIA ids created for main-menu panel #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accessibility score on Create Tag page increased from 85 to 91.
It also increases the accessibility score by 6 points on every page showing the main-menu panel on the left.
Issue description
The menu panel on the left uses a for loop to render the panel headings. However, the ids were all named "headingOne". According to web.dev, using the same ID on more than one element may cause screen readers and other assistive technologies to only announce the first element with the shared ID, preventing users from accessing the later elements.
Solution Implemented
I associated the id with a for loop counter, which would associate a unique iteration number in the id and thus resolve the issue. For example, the second panel item now shows "headingOne-2" instead of "headingOne".
resolves #40