Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest pandas #42

Open
wangjiawen2013 opened this issue Jan 12, 2024 · 5 comments
Open

latest pandas #42

wangjiawen2013 opened this issue Jan 12, 2024 · 5 comments

Comments

@wangjiawen2013
Copy link

Hi,
The latest pandas is 2.1.0, while pyroe needs pandas <= 1.5. Lots of packages now depend on pandas >= 2.0. Degrading pandas to 1.5 will cause some compatibility issues with other packages. So could you update pandas ?

@rob-p
Copy link
Contributor

rob-p commented Jan 12, 2024

Thanks for the update. Last I recall, the problem was recursive due to an upstream dependency on pyranges that was using Pandas < 2. I'm pinging @DongzeHE here.

I'll note that, in general, we recommend to upgrade / change to roers for building splici and spliceu transcriptomes. In addition to being faster and more memory friendly (it's written in Rust), the main motivation of re-implementing the reference building functionality of pyroe in roers was actually to avoid the constant dependency management challenges introduced by Python (and by the pyranges dependency in particular).

@wangjiawen2013
Copy link
Author

I would like to change to roers, is it supported by simpleaf now ? simpleaf is a rust framework to make using alevin-fry even simpler. It recommends to use pyroe in its documentation.
https://github.com/COMBINE-lab/simpleaf

@rob-p
Copy link
Contributor

rob-p commented Jan 14, 2024

Hi @wangjiawen2013,

Yes! One of the (additional) benefits of moving from from pyroe to roers is that, since roers is a rust library, we can directly include it in simpleaf, rather than having to make the user put an additional tool in their path. If you download a recent (we recommend the most recent) release of simpleaf, it will have roers included, and will use that by default for reference generation.

It looks like we need to update the docs, @DongzeHE! Thanks for pointing this out @wangjiawen2013. Let us know if this works for you and, if so, we can close this issue.

Best,
Rob

@wangjiawen2013
Copy link
Author

wangjiawen2013 commented Jan 25, 2024

According to alevin's tutorial, we can Load output using pyroe (https://combine-lab.github.io/alevin-fry-tutorials/2023/simpleaf-piscem/):

# Run in python
from pyroe import load_fry

#define count matrix format
custom_format = {'X' : ['S', 'A'],
                 'unspliced' : ['U']}

# load count matrix
adata = load_fry("pbmc1k_quant/af_quant",
                 output_format = custom_format)

But how to load the output using roers ? I typed "from roers import load_fry", but it showed an error "ModuleNotFoundError: No module named 'roers'"

@DongzeHE
Copy link
Collaborator

Hello @wangjiawen2013 , we are working on updating pyroe. For now, a workaround is that you can define the load_fry function directly in your script. You can find the function from here, and copy and paste of load_fry.py in your script. This function is very stable and we do not expect to update it in the near future. The only dependency of this function is scanpy

Sorry for the inconvenience. Please let us know if you encounter any problems!

Best,
Dongze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants