Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metax bulk patch returns 200 if at least one dataset is updated causing submitter miss the error #511

Open
genie9 opened this issue Jun 29, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@genie9
Copy link
Contributor

genie9 commented Jun 29, 2022

Describe the bug

Submitter uses bulk patch call to Metax before publishing submission to update metadata to the latest. If the study or some datasets fail to validate on Metax side but at least one passes Metax will still return HTTP200 and the response will have the form:
{"success": <successed datasets>, "failed": <failed datasets>}

To Reproduce

This behavior can be reproduced by

  • not mapping some required value for Metax e.g. other_identifier[].type.identifier" which are mapped from alternateIdentifiers
  • using demo server for Metax instead of mocked API
  • there will be failing submission publishing but no visible error
    To see what's wrong with the dataset same mapped metadata should be sent as request body directly to Metax with PATCH https://metax.demo.fairdata.f/rest/v2/datasets.

Expected behavior

There should be an indication of which dataset failed to be updated to Metax. This can be achieved by e.g. replacing use of a bulk patch to separate object patching.

@genie9 genie9 added the bug Something isn't working label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant