Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify DAC and policy implementations #588

Open
4 tasks
Tracked by #591
csc-felipe opened this issue Sep 26, 2022 · 0 comments
Open
4 tasks
Tracked by #591

Unify DAC and policy implementations #588

csc-felipe opened this issue Sep 26, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@csc-felipe
Copy link
Contributor

csc-felipe commented Sep 26, 2022

Proposed solution

Currently we have two distinct implementations for DAC and policy.

  1. From EGA schema
  2. From REMS

and they are not connected in any way.

Tasks

  • Design unification for both implementations
    The proposed solution would be to:

    1. Rename, in the submission schema dac to rems Rename submission.dac to submission.rems #648
    2. Accept EGA XML and validate against data that lives in REMS - adding EGA DAC object to DB, and configuring the submission.rems field
    3. When setting REMS fields through the API (including front-end), create (or replace) the EGA DAC object to DB. Create EGA DAC when REMS DAC is submitted #532
  • Make code changes

  • Update tests

  • Create ticket for the frontend

DoD (Definition of Done)

DAC and policy implementations are unified, and interchangeable.

Testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants