resource_id and catalogue_item_id don't belong in submission.json

[csc-felipe]

Describe the bug

These lines don't belong in the submission schema. They should belong to a dataset object.

metadata-submitter/metadata_backend/helpers/schemas/submission.json

Lines 1190 to 1197 in 0f11942

	"resourceId": {
	"type": "string",
	"title": "REMS id of the resource created. Created automatically during the publication process"
	},
	"catalogueItemId": {
	"type": "string",
	"title": "REMS id of the catalogue created. Created automatically during the publication process"
	}

They should be safe to remove, as no code adds those to a submission. It is instead added to datasets in the publication phase.

metadata-submitter/metadata_backend/api/handlers/publish.py

Lines 423 to 435 in 0f11942

	await obj_op.update_metadata_object(
	ds["schema"],
	ds["accession_id"],
	{
	"dac": {
	"url": rems_url,
	"workflowId": workflow_id,
	"organizationId": org_id,
	"resourceId": resource_id,
	"catalogueId": catalogue_id,
	},
	},
	)

Additional context

Thanks to @blankdots for figuring out the issue in the discussion in #648

[csc-jm]

So should that dac (now renamed to rems) field and its properties be added to both EGA and BP json schemas?

[csc-felipe]

I don't think those should be changed. Does @blankdots have an opinion?

One possible solution would be to put it in the submission's metadataObject field

[blankdots]

One possible solution would be to put it in the submission's metadataObject field

I was thinking more in extraInfo > datasetIdentifiers as it is related to dataset the rems workflow, resource and catalogue item, however metadataObject works as well