Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group and Mineral IDs - Integers vs Objects #1

Open
morganjwilliams opened this issue Jul 25, 2024 · 0 comments
Open

Group and Mineral IDs - Integers vs Objects #1

morganjwilliams opened this issue Jul 25, 2024 · 0 comments

Comments

@morganjwilliams
Copy link
Member

When incorporating mineral and group names from TSG outputs, these could be alternately stored as integers/IDs which point to a mapping (efficient for storage), or strings/objects (where a mapping is retained principally for back-compatibility/traceability). Currently this is mixed between mineral and group names, and perhaps should be standardised - either with an option during reading, or simply taking e.g. the latter option by default.

Given that common export formats (i.e., Zarr) would likely handle some of the compression aspects, storing strings for user-friendliness might make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant