Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability in docker compose #38

Open
aaraney opened this issue Dec 27, 2021 · 0 comments
Open

Security vulnerability in docker compose #38

aaraney opened this issue Dec 27, 2021 · 0 comments
Assignees

Comments

@aaraney
Copy link

aaraney commented Dec 27, 2021

@Castronova, it looks like 73328c5 and 57f7baa introduced security vulnerabilities with the inclusion of oauth configuration data. We probably should prune these commits from the tree (this will be a pain) or at the least, they should be removed and new oauth configuration secrets be generated.

In the future, we should use a docker .env file that is never added to this repo that contains this and any other sensitive data. See the compose docs for examples. Likewise, I see that the ssl certs are being accessed from a volume mount, we probably should move these to docker-compose secrets that are treated with more care and are always read only. See the compose docs on this subject for an example (I also included one below).

version: "3.9"
services:
  redis:
    image: redis:latest
    environment: 
      SSL_CERT: /run/secrets/ssl_cert
    secrets:
      - ssl_cert
secrets:
  ssl_cert:
    file: "${SSL_CERT}"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants