Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: traceback in the parallel notebook doesn't fail CI status #18

Open
bsipocz opened this issue Aug 20, 2024 · 1 comment
Open

BUG: traceback in the parallel notebook doesn't fail CI status #18

bsipocz opened this issue Aug 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bsipocz
Copy link
Member

bsipocz commented Aug 20, 2024

There is a traceback in the Dask case for the parallel notebook, and somehow this doesn't fail the CI or execution and rendering.

I see no sign of this in the pytest jobs (which uses nbval), but the traceback is present with myst-nb execution.

https://github.com/Caltech-IPAC/irsa-tutorials/actions/runs/10466243659/job/28982790720#step:5:242

https://caltech-ipac.github.io/irsa-tutorials/tutorials/parallelize/Parallelize_Convolution.html#process-using-dask

start = time.time()
image = np.zeros((3000, 3000))
for _ in range(100):
    for j in range(num_cpus):
        big_future = client.scatter((image, filters[j % num_cpus]))
        future = client.submit(fconv, big_future)
duration_dask = time.time() - start
print("Dask duration = {:.1f}, speedup = {:.2f}"
      .format(duration_dask, duration_conv*num_cpus / duration_dask))

2024-08-20 06:26:59,687 - distributed.worker - ERROR - Compute Failed
Key:       fconv-62d3fb08cdcd4722add20d9c193727a4
State:     executing
Function:  fconv
args:      ((array([[0., 0., 0., ..., 0., 0., 0.],
       [0., 0., 0., ..., 0., 0., 0.],
       [0., 0., 0., ..., 0., 0., 0.],
       ...,
       [0., 0., 0., ..., 0., 0., 0.],
       [0., 0., 0., ..., 0., 0., 0.],
       [0., 0., 0., ..., 0., 0., 0.]]), array([[ 0.04511129, -0.36965459, -0.95263628, -0.14601954],
       [-0.59376302, -0.84903493, -0.89073568, -0.66741073],
       [-0.47099116, -1.10903786,  1.44708216,  0.12989074],
       [-1.48281771, -1.25057209, -0.32882889,  0.46543018]])))
kwargs:    {}
Exception: 'TypeError("fconv() missing 1 required positional argument: \'random_filter\'")'
Traceback: ''
@bsipocz bsipocz added the bug Something isn't working label Aug 20, 2024
@bsipocz
Copy link
Member Author

bsipocz commented Sep 27, 2024

Note that #34 fix the traceback, but I keep this issue open as CI should have failed on it, and thus this should only be closed once the test configs produce a failing status on the commit before #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant